Default SFF8472 xcvr cable type to Unknown #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bobby-nexthop
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow the pattern from sff8436.py and default to "Unknown" to prevent
None being returned.
Fixes sonic-net/sonic-buildimage#24369
Description
If the transceiver does not have one of the expected length-types, it
will be returned as None, which will cause an exception in xcvrd's
post_port_sfp_info_to_db() when it tries to marshal that data into a
swsscommon.FieldValuePairs because None is not a string.
Motivation and Context
We were seeing a continuous crash loop on NH-4010 when loopback
transceivers were installed.
How Has This Been Tested?
Verified it stopped the continuous crash loop on NH-4010 when the
appropriate loopbacks are installed.
Additional Information (Optional)